Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix IfcBuildingStorey elevation sort #1721

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

xeolabs
Copy link
Member

@xeolabs xeolabs commented Nov 5, 2024

StoreyViewsPlugin sorts its Storey objects on the elevation attribute that belongs to each Storey's IfcBuildingStorey.

TreeViewPlugin likewise sorts nodes that represent IfcBuildingStoreys.

The attribute can be either a string or a number.

This PR ensures that these two plugins always parse the attribute correctly into a float.

@xeolabs xeolabs merged commit 8bfb3a3 into master Nov 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant