-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XCD-144 Fix shaking measurement #1719
Conversation
With this PR, what is the behaviour of measurent controls when they intersect the front clipping plane? |
The lines are visible even when they are "behind" the camera, which is no good I guess. |
558377a
to
3bccfdf
Compare
3bccfdf
to
1f1a3dd
Compare
1f1a3dd
to
c7d5dd6
Compare
I've tested the branch with all examples under https://xeokit.github.io/xeokit-sdk/examples/measurement/, all worked correctly. |
Not sure what was the original intention to hide measurement controls when camera was too close to them, but it causes glitches as described at https://creoox.atlassian.net/browse/XCD-175?focusedCommentId=13492
Removing this special logic seems to fix the reported issue.