Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCD-144 Fix shaking measurement #1719

Merged
merged 11 commits into from
Nov 28, 2024
Merged

Conversation

MichalDybizbanskiCreoox
Copy link
Collaborator

Not sure what was the original intention to hide measurement controls when camera was too close to them, but it causes glitches as described at https://creoox.atlassian.net/browse/XCD-175?focusedCommentId=13492
Removing this special logic seems to fix the reported issue.

@xeolabs
Copy link
Member

xeolabs commented Oct 31, 2024

With this PR, what is the behaviour of measurent controls when they intersect the front clipping plane?

@MichalDybizbanskiCreoox
Copy link
Collaborator Author

The lines are visible even when they are "behind" the camera, which is no good I guess.
The opposite is not good either though, because if one end of a line is behind the camera, but the other is in front of it, a part of the line should be visible, but that's tricky to achieve with DOM elements.

@MichalDybizbanskiCreoox MichalDybizbanskiCreoox marked this pull request as draft October 31, 2024 15:58
@MichalDybizbanskiCreoox
Copy link
Collaborator Author

MichalDybizbanskiCreoox commented Nov 18, 2024

The PR has been updated since the previous comment to introduce a significant change to the architecture of DOM elements (Dot, Wire, Label) visuals management.
Instead of being managed from a plugin abstraction that uses them (e.g. a DistanceMeasurement) the elements are now responsible for responding to view-related changes (camera, section planes etc) by themselves.
image

@MichalDybizbanskiCreoox MichalDybizbanskiCreoox force-pushed the XEOK-144-fix-shaking-measurement branch from 3bccfdf to 1f1a3dd Compare November 18, 2024 15:40
@MichalDybizbanskiCreoox MichalDybizbanskiCreoox force-pushed the XEOK-144-fix-shaking-measurement branch from 1f1a3dd to c7d5dd6 Compare November 28, 2024 20:56
@MichalDybizbanskiCreoox MichalDybizbanskiCreoox marked this pull request as ready for review November 28, 2024 20:57
@MichalDybizbanskiCreoox
Copy link
Collaborator Author

I've tested the branch with all examples under https://xeokit.github.io/xeokit-sdk/examples/measurement/, all worked correctly.

@xeolabs xeolabs merged commit cdc4008 into master Nov 28, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants