Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Show correct distance for z axis when useRotationAdjustment is false #1556

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

jbenhardus
Copy link
Contributor

@jbenhardus jbenhardus commented Jun 26, 2024

Update measurement to show correct distance and label for z axis when useRotationAdjustment is false

Before:

Screenshot 2024-06-26 at 11 24 16 AM

Note that the total distance comes to sqrt(5.19^2 + 5.43^2 + 6.60^2) = 9.99905 and not 8.55 as expected.
Also note that the prefix is missing for the Z axis.

After:
Screenshot 2024-06-26 at 11 27 57 AM

Total distance is sqrt(5.19^2 + 5.43^2 + 4.10^2) = 8.55 and prefix is Z as expected.

@xeolabs
Copy link
Member

xeolabs commented Jun 27, 2024

Hi! Thanks for the PR. Before we merge, could you please sign this contributor's agreement and get it back to us at [email protected]: https://teams.microsoft.com/v2/?tenantId=b86de661-e09d-49b2-8805-2c9eb657625c

@jbenhardus
Copy link
Contributor Author

@xeolabs sure thing! However, I am not able to access that link. Is there an alternate link that doesn't require a Microsoft Teams login?

@xeolabs
Copy link
Member

xeolabs commented Jun 27, 2024

Gotcha - try this one: CLA - Creoox - Individual.pdf

@xeolabs xeolabs merged commit c52fd8d into xeokit:master Jun 27, 2024
1 check passed
@xeolabs xeolabs changed the title show correct distance for z axis when useRotationAdjustment is false [FIX] Show correct distance for z axis when useRotationAdjustment is false Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants