Copying to SFTP is very slow compared to native/SSHJ #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hierynomus
added a commit
that referenced
this pull request
Oct 12, 2015
Copying to SFTP is very slow compared to native/SSHJ
|
XebiaLabs » overthere #42 SUCCESS |
| try { | ||
| // If the source is a directory and the name and the target name do not match, SFTP copies the | ||
| // directory into the destination, whereas we want to copy the contents into the destination. | ||
| if (source.isDirectory() && this.exists() && !source.getName().equals(this.getName())) { |
There was a problem hiding this comment.
Do we need to take into account issues related to the case of the name here? E.g. an SSH implementation running on Windows?
There was a problem hiding this comment.
Actually SSHJ also does not take that into account. This check is merely there to counteract the check in SSHJ that it creates a subdir :)
There was a problem hiding this comment.
|
Nice! Thanks, @hierynomus! |
|
Ah, OK - thanks for the link! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying files from local to SFTP, Overthere is twice slower than either native
sshor usingSSHJdirectly.This PR fixes #164 (and is the correct version of #165)