Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method setExecutable should invoke chmod a+x instead of chmod +x #39

Closed
vpartington opened this issue Mar 20, 2012 · 2 comments
Closed

Method setExecutable should invoke chmod a+x instead of chmod +x #39

vpartington opened this issue Mar 20, 2012 · 2 comments

Comments

@vpartington
Copy link
Contributor

When setExecutable is called on an SshScpFile, the command "chmod +x" is executed. This should be "chmod a+x" to prevent the umask from preventing some of the executable bits from being set.
vpartington pushed a commit that referenced this issue Mar 20, 2012
DEPLOYITPB-3141 DEPLOYITPB-3142 Github #39 Github #40 Method setExecu…
440fb2e 
…table invokes chmod a+x instead of chmod +x, current working directory not set using "cd" when invoking commands for SshScpFile.

- Improved logging of SshScpFile.getInputStream() and SshScpFile.getOutputStream().
- Improved logging of handling of "sudo" and "cd" and the corresponding pseudocommands "nosudo" and "nocd".
@vpartington
Copy link
Contributor Author

Fixed in Overthere 1.0.17.

vpartington pushed a commit that referenced this issue Mar 20, 2012
DEPLOYITPB-3141 DEPLOYITPB-3142 Github #39 Github #40 Method setExecu…
2d97760 
…table invokes chmod a+x instead of chmod +x, current working directory not set using "cd" when invoking commands for SshScpFile.

- Improved logging of SshScpFile.getInputStream() and SshScpFile.getOutputStream().
- Improved logging of handling of "sudo" and "cd" and the corresponding pseudocommands "nosudo" and "nocd".

Conflicts (imports only):

	overthere/src/main/java/com/xebialabs/overthere/ssh/SshSudoConnection.java
@hierynomus
Copy link
Contributor

Commit is on master to be included in 2.0.0

vpartington pushed a commit that referenced this issue Aug 2, 2012
@hierynomus
DEPLOYITPB-3141 DEPLOYITPB-3142 Github #39 Github #40 Method setExecu…
8257476 
…table invokes chmod a+x instead of chmod +x, current working directory not set using "cd" when invoking commands for SshScpFile.

- Improved logging of SshScpFile.getInputStream() and SshScpFile.getOutputStream().
- Improved logging of handling of "sudo" and "cd" and the corresponding pseudocommands "nosudo" and "nocd".

Conflicts (imports only):

	overthere/src/main/java/com/xebialabs/overthere/ssh/SshSudoConnection.java
vpartington pushed a commit that referenced this issue Aug 2, 2012
@hierynomus
DEPLOYITPB-3141 DEPLOYITPB-3142 Github #39 Github #40 Method setExecu…
5ecbb56 
…table invokes chmod a+x instead of chmod +x, current working directory not set using "cd" when invoking commands for SshScpFile.

- Improved logging of SshScpFile.getInputStream() and SshScpFile.getOutputStream().
- Improved logging of handling of "sudo" and "cd" and the corresponding pseudocommands "nosudo" and "nocd".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hierynomus @vpartington