transforms: use Rewriter instead of PatternRewriter in mlir-opt #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PatternRewriter` should only be used for rewrite patterns. stack-info: PR: #3537, branch: math-fehr/stack/1
math-fehr
force-pushed
the
math-fehr/stack/1
branch
from
dae783a to
eb30740
Compare
This was referenced Nov 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3537 +/- ##
=======================================
Coverage 90.36% 90.36%
=======================================
Files 466 466
Lines 58517 58516 -1
Branches 5583 5583
=======================================
+ Hits 52878 52879 +1
+ Misses 4210 4209 -1
+ Partials 1429 1428 -1 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Nov 29, 2024
alexarice
approved these changes
Dec 2, 2024
compor
approved these changes
Dec 4, 2024
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
…project#3537) Stacked PRs: * xdslproject#3540 * xdslproject#3539 * xdslproject#3538 * __->__#3537 --- --- --- ### transforms: use Rewriter instead of PatternRewriter in mlir-opt `PatternRewriter` should only be used for rewrite patterns.
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
…il (xdslproject#3538) Stacked PRs: * xdslproject#3540 * xdslproject#3539 * __->__#3538 * xdslproject#3537 --- --- --- ### transforms: use rewriter and listener in convert-stencil-to-csl-stencil The pass was not propagating the listener from the PatternRewriter, and thus some operations were modified without notifying the rewrite worklist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
transforms: use Rewriter instead of PatternRewriter in mlir-opt
PatternRewritershould only be used for rewrite patterns.