Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: keep action sheet's origin after rotation on iPad #1204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wutschel
Copy link
Collaborator

@wutschel wutschel commented Dec 6, 2024

Description

Fixes an issue reported in this forum post, as well as a problem found during testing.

  1. Present sort-by action from buttonsView. This lets the origin stay at the right place when rotating iPad.
  2. Present other action sheets from self.view. Fixes origins not moving correctly when rotating, e.g. when long pressing albums in Music > Artists > Albums.

Summary for release notes

Bugfix: keep action sheet's origin after rotation on iPad

@wutschel wutschel added the bugfix label Dec 6, 2024
This lets the origin stay at the right place when rotating iPad.
Fixes origins not moving correctly when rotating, e.g. when long pressing albums in Music > Artists > Albums.
@wutschel wutschel changed the title Bugfix: keep sort-by action sheet's origin after rotation on iPad Bugfix: keep action sheet's origin after rotation on iPad Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant