Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated accessors.py #115

Closed
wants to merge 1 commit into from
Closed

Updated accessors.py #115

wants to merge 1 commit into from

Conversation

vedant-gawande
Copy link

Just did some small assignment task to remove this small error of walrus operator(:=) which will make the module xwrf run even in unupdated versions of python solving the import error

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

Just did some small assignment task to remove this small error of walrus operator(:=) which will make the module xwrf run even in unupdated versions of python solving the import error
@jthielen
Copy link
Collaborator

Thank you for offering this contribution! However, Python versions older than 3.8 are not being supported by most of the community (see NEP 29 already at 3.8 minimum and conda-forge dropping 3.7 in the coming days), which means that xwrf trying to support such outdated Python versions would be an undue maintenance burden (e.g., custom CI builds, increased complexity in dependency management). So, with xwrf only supporting Python >= 3.8, this PR's change is unfortunately not worthwhile. If you are currently using Python <= 3.7, I highly encourage you to focus your efforts on modernizing your environment (be it yourself or working with a sysadmin) to regularly update and keep pace with the present Scientific Python community (for example, in about 6 months, many packages will have Python 3.9 as their minimum version).

@jthielen jthielen closed this Oct 22, 2022
@vedant-gawande
Copy link
Author

Understood!
so it is plausible to close the issue : SyntaxError encountered upon import #114
as in newer versions walrus operator is supported so no error while importing xwrf.

@jthielen
Copy link
Collaborator

Understood! so it is plausible to close the issue : SyntaxError encountered upon import #114 as in newer versions walrus operator is supported so no error while importing xwrf.

Correct, we are just waiting for a response from the issue's author to verify that was indeed their issue prior to closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants