[ci] Support stable publishing and passwordless auth for darc/maestro #20914

pjcollins · 2024-07-17T21:52:30Z

We've seen the build promotion pipeline fail when trying to publish
stable package versions:

error : Package 'Microsoft.iOS.Ref.net8.0_17.5' has stable version '17.5.8001' but is targeted at a non-isolated feed 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json'

This is because we were not declaring these packages as stable when
building the build asset registry manifest.

Fix this by passing the $NUGET_PRERELEASE_IDENTIFIER variable to the
build asset manifest creation task to determine if a build is stable.

When $(IsStableBuild) is set to true, packages will be pushed to an
isolated feed during publishing, such as:

  Package [email protected] (Shipping) should go to https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-android-b8317b6f/nuget/v3/index.json (Isolated, Public)

Additionally migrates darc/maestro commands to use a passwordless auth flow,
as token-based authentication will be removed in the future.

We've seen the build promotion pipeline fail when trying to publish stable package versions: error : Package 'Microsoft.iOS.Ref.net8.0_17.5' has stable version '17.5.8001' but is targeted at a non-isolated feed 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json' This is because we were not declaring these packages as stable when building the build asset registry manifest. Fix this by adding a new `$NUGET_HARDCODED_IS_STABLE_BUILD` variable to pass to the build asset manifest creation task. This property needs to be updated manually when switching to stable package versioning. When `$(IsStableBuild)` is set to true, packages will be pushed to an isolated feed during publishing, such as: Package [email protected] (Shipping) should go to https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-android-b8317b6f/nuget/v3/index.json (Isolated, Public)

Make.config

…tablepub

dotnet/Makefile

dotnet/package/common.csproj

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

…tablepub

pjcollins · 2024-08-14T13:23:24Z

Latest test run here is finally looking good https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10043920&view=logs&j=45f1b321-fe00-5774-563c-3f6362fe97e5&t=78e7a630-f150-5fdc-53e4-2ece06bdb113

vs-mobiletools-engineering-service2 · 2024-08-14T15:34:30Z

📚 [CI Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-08-14T15:50:04Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: a1eb286114cf99e6de7b0cca2139ccefd2bfc21a [PR build]

vs-mobiletools-engineering-service2 · 2024-08-14T15:56:48Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: a1eb286114cf99e6de7b0cca2139ccefd2bfc21a [PR build]

vs-mobiletools-engineering-service2 · 2024-08-14T15:57:26Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: a1eb286114cf99e6de7b0cca2139ccefd2bfc21a [PR build]

vs-mobiletools-engineering-service2 · 2024-08-14T16:07:27Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: a1eb286114cf99e6de7b0cca2139ccefd2bfc21a [PR build]

vs-mobiletools-engineering-service2 · 2024-08-14T18:02:31Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 170 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 6 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ install-source: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 7 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac-binding-project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (watchOS): All 4 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: a1eb286114cf99e6de7b0cca2139ccefd2bfc21a [PR build]

vs-mobiletools-engineering-service2 · 2024-08-15T08:30:36Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: a1eb286114cf99e6de7b0cca2139ccefd2bfc21a [PR build]

…#20914) Context: dotnet/android#9164 We've seen the build promotion pipeline fail when trying to publish stable package versions: error : Package 'Microsoft.iOS.Ref.net8.0_17.5' has stable version '17.5.8001' but is targeted at a non-isolated feed 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json' This is because we were not declaring these packages as stable when building the build asset registry manifest. Fix this by passing the `$NUGET_PRERELEASE_IDENTIFIER` variable to the build asset manifest creation task to determine if a build is stable. When `$(IsStableBuild)` is set to true, packages will be pushed to an isolated feed during publishing, such as: Package [email protected] (Shipping) should go to https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-android-b8317b6f/nuget/v3/index.json (Isolated, Public) Additionally migrates darc/maestro commands to use a passwordless auth flow, as token-based authentication will be removed in the future.

pjcollins commented Jul 17, 2024

View reviewed changes

Make.config Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

pjcollins marked this pull request as ready for review July 18, 2024 19:18

pjcollins requested a review from rolfbjarne as a code owner July 18, 2024 19:18

pjcollins requested review from mandel-macaque and mcumming July 18, 2024 19:18

dalexsoto approved these changes Jul 22, 2024

View reviewed changes

Make.config Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/net9.0' into release-test/net9-s…

0abe83a

…tablepub

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Aug 1, 2024

View reviewed changes

dotnet/Makefile Outdated Show resolved Hide resolved

dotnet/package/common.csproj Outdated Show resolved Hide resolved

pjcollins and others added 3 commits August 1, 2024 14:13

Apply suggestions from code review

a47a28a

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

Review feedback

4c64a83

Merge remote-tracking branch 'origin/net9.0' into release-test/net9-s…

2e131b9

…tablepub

pjcollins requested a review from rolfbjarne August 1, 2024 18:17

Remove unused var

f90450b

rolfbjarne approved these changes Aug 1, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

pjcollins added 2 commits August 13, 2024 23:59

Revert invoking dotnet build from make

c99b1c5

Escape vso logging command

a870e10

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/net9.0' into release-test/net9-s…

a1eb286

…tablepub

pjcollins marked this pull request as ready for review August 14, 2024 13:23

pjcollins requested review from mandel-macaque and rolfbjarne August 14, 2024 13:23

rolfbjarne approved these changes Aug 15, 2024

View reviewed changes

pjcollins merged commit 2562461 into net9.0 Aug 15, 2024
21 of 23 checks passed

pjcollins deleted the release-test/net9-stablepub branch August 15, 2024 14:58

[ci] Support stable publishing and passwordless auth for darc/maestro #20914

[ci] Support stable publishing and passwordless auth for darc/maestro #20914

Conversation

pjcollins commented Jul 17, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pjcollins commented Aug 14, 2024

vs-mobiletools-engineering-service2 commented Aug 14, 2024

📚 [CI Build] Artifacts 📚

vs-mobiletools-engineering-service2 commented Aug 14, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Aug 14, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Aug 14, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Aug 14, 2024

❌ [CI Build] Windows Integration Tests failed ❌

vs-mobiletools-engineering-service2 commented Aug 14, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

vs-mobiletools-engineering-service2 commented Aug 15, 2024

💻 [CI Build] Windows Integration Tests passed 💻

pjcollins commented Jul 17, 2024 •

edited

Loading