New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Improve maestro artifact publishing #20665

Merged

pjcollins merged 15 commits into main from release-test/pjc-barmanupdate

Jun 4, 2024

Member

pjcollins commented May 30, 2024

The steps used to publish build asset information to maestro have been
updated. The post build stage has been disabled for main and .NET 9, as
maestro manifest generation and channel promotion will now run as part
of the "Prepare .NET Release" stage.

With the new PushToAzureDevOpsArtifacts task the build pipeline should
now create all of the artifacts required for maestro artifact publishing.
The add-build-to-channel darc command will now trigger a
Build Promotion Pipeline that pushes build assets to the feed that
corresponds to the maestro channel that is being updated. We should
no longer need to push assets to various NuGet feeds in a separate step.

pjcollins and others added 9 commits

May 15, 2024 11:04


          [ci] Improve maestro artifact publishing

0bfb78d

Context: https://github.com/dotnet/arcade/blob/efc3da96e5ac110513e92ebd9ef87c73f44d8540/Documentation/DependencyFlowOnboardingWithoutArcade.md

The steps used to publish build asset information to maestro have been
updated.

With the new `PushToAzureDevOpsArtifacts` task the build pipeline should
now create all of the artifacts required for maestro artifact publishing.
The `add-build-to-channel` darc command will now trigger a
[Build Promotion Pipeline][0] that pushes build assets to the feed that
corresponds to the maestro channel that is being updated.  We should
no longer need to push assets to various NuGet feeds in a separate step.

[0]: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=9577012&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=c7a8693b-2f9c-5ea8-c909-cde9405ac2e1&l=238


          Merge branch 'main' into dev/pjc/barmanupdate

f5952e8


          Merge remote-tracking branch 'origin' into dev/pjc/barmanupdate

9e91712


          Disable post build, move maestro steps to vs-insertion template

3f6ad68


          Fix path

ee707fe


          Update working dir

8a2eaf4


          Fix workingdir param

349a6cd


          Update variable groups, post pipeline

fba198d


          Fix typo

ddbefed

pjcollins mentioned this pull request

[ci] Improve maestro artifact publishing #20604

Closed

pjcollins requested review from rolfbjarne and mandel-macaque

May 30, 2024 16:02

Member Author

pjcollins commented May 30, 2024 •

edited

Loading

Successful test build can be found here:

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9651926&view=logs&j=45f1b321-fe00-5774-563c-3f6362fe97e5&t=d5aaaad1-912f-5aa2-63da-3a7555914b3b&l=46

And I manually triggered the following job via a darc add-build-to channel command (as this branch has no default maestro channels configured) to further test arcade publishing, which is working as well:

https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=9654802&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=c7a8693b-2f9c-5ea8-c909-cde9405ac2e1&l=238


          Merge remote-tracking branch 'origin/main' into release-test/pjc-barm…

d9b4f97

…anupdate

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view


          Remove no longer used build-nugets template

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view


          Build project associated with first included platform

88aa3db

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

pjcollins added 2 commits

May 31, 2024 17:41


          Revert "Test publish with platforms disabled"

f5d77de

This reverts commit aff141d.


          Merge remote-tracking branch 'origin/main' into release-test/pjc-barm…

380310f

…anupdate

pjcollins requested a review from rolfbjarne

May 31, 2024 21:43

Collaborator

vs-mobiletools-engineering-service2 commented May 31, 2024

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented May 31, 2024

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented May 31, 2024

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented May 31, 2024

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented May 31, 2024

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11) passed.

Pipeline on Agent
Hash: [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented May 31, 2024

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 380310f23c1c5dbd2558b809fa00a9e433ff6ffa [PR build]

Collaborator

vs-mobiletools-engineering-service2 commented May 31, 2024

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 380310f23c1c5dbd2558b809fa00a9e433ff6ffa [PR build]

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes

View reviewed changes

Member

rolfbjarne left a comment

LGTM, but I'd like Manuel to have a look at it too.

Member Author

pjcollins commented Jun 3, 2024

LGTM, but I'd like Manuel to have a look at it too.

Thanks! @mandel-macaque this one should be ready whenever you have the chance to take a look

mandel-macaque approved these changes

View reviewed changes

pjcollins merged commit 2abbaf9 into main

163 of 168 checks passed

pjcollins deleted the release-test/pjc-barmanupdate branch

June 4, 2024 16:40

pjcollins added a commit that referenced this pull request


          Revert "[ci] Improve maestro artifact publishing (#20665)"

f5fffdd

This reverts commit 2abbaf9.

These publishing changes were intended for .NET 9.0+, and they require
some additional work to be compatible with stable package versioning.

dalexsoto added a commit that referenced this pull request


          Revert "[ci] Improve maestro artifact publishing (#20665)" (#20904)

30b5e80

This reverts commit 2abbaf9.

These publishing changes were intended for .NET 9.0+, and they require
some additional work to be compatible with stable package versioning.

---------

Co-authored-by: Alex Soto <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet