-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/full wildcard support #68
Feature/full wildcard support #68
Conversation
Add wildcard support for groupId and artifactId Remove regex support
Thanks for your contribution! This is quite a big change, @cmorty would you like to review? |
@wvengen yes, will do after some last personal things related to GDPR ;) probably next sunday |
@wvengen Can you merge this request and create a release ? |
I've encountered this too and this PR seems to fix the issue. Is there anything else to be done? |
@Chuckame would it be possible to add some example usages to the documentation (index.apt)? |
@lasselindqvist I added some here: https://github.com/cjgriscom/proguard-maven-plugin/tree/feature/full-wildcard-support I can also confirm that the plugin works correctly for me. |
Hi.
Actually, wildcards are not fully supported.
My proposition:
.*
).*
every where in groupId or artifactId like :my.group*
(takesmy.group
,my.group-extension
,my.group.subgroup
, ...)my*artifact
(takesmyartifact
,mysuperlongartifact
, ...)myproject-*
(takesmyproject-libs
,myproject-components
, ...)*
(takes all)Fix bug: