added generateTemporaryConfigurationFile option #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| FileWriter writer = new FileWriter(temporaryConfigurationFile); | ||
| IOUtils.write(stringBuilder.toString(), writer); | ||
| writer.close(); |
There was a problem hiding this comment.
Writer needs closing even in case of errors, so this needs to be done in a finally block or with
try(FileWriter write = new FileWriter(temporaryConfigurationFile); ) {
}
There was a problem hiding this comment.
I replaced it with a java 1.6 compatible finally.
| @@ -132,6 +133,19 @@ | |||
| */ | |||
| private boolean putLibraryJarsInTempDir; | |||
|
|
|||
| /** | |||
| * Create a temporary configuration file | |||
There was a problem hiding this comment.
Needs a bit more explanation for this feature.
For example: "Use this parameter if your command line arguments become too long and execution fails. If this parameter is true, the arguments are written to a file and the Proguard process reads them from the file instead of the command itself.
There was a problem hiding this comment.
Done. Also updated the maven documentation.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
putLibraryJarsInTempDirdid not work for me. My project had to many -injars, not libraries.This pull request introduces a new option
generateTemporaryConfigurationFilethat generates a temporary proguard configuration file that includes all arguments.The pull request does not modify other options.
fixes #113