Respect filter on library merge

[nicymike]

I need to add jackson to my project but I there are some files I don't want to be included in the final jar. This pull request addresses the fact that filter is beeing ignored on libraries.

I tested the code and verified that the filter is now working.

Example pom:

<inclusion>
  <groupId>com.fasterxml.jackson.core</groupId>
  <artifactId>jackson-databind</artifactId>
  <!-- Some files should not be included in jar -->
  <filter>!META-INF/maven/**,!META-INF/LICENSE,!META-INF/MANIFEST.MF,!META-INF/NOTICE</filter>
  <library>true</library>
</inclusion>

[lasselindqvist]

Is this method deprecated in favor of http://codehaus-plexus.github.io/plexus-archiver/apidocs/org/codehaus/plexus/archiver/Archiver.html#addArchivedFileSet(org.codehaus.plexus.archiver.ArchivedFileSet)
in the version we use? Can we use the preferred one?

[nicymike]

It is not deprecated yet and also not in newest maven-archiver version 3.5.0 which includes plexus-archiver 2.4.
I can change my code to use the new method if you want.

Btw. maven-archiver used in this plugin is more than ten years old:
https://search.maven.org/artifact/org.apache.maven/maven-archiver

[lasselindqvist]

addArchivedFileSet(File archiveFile, String[] includes, String[] excludes)
is deprecated in that link, but
addArchivedFileSet(ArchivedFileSet fileSet)
is not.

Not sure since which version that is though, probably the newest. (4.2.2?)
Anyway, not necessary to change that since the new method might not even exist in the version we use.

[nicymike]

You are right, the link points to 4.2.2 where the method mentioned is deprecated.
Regarding to my IDE the used version in proguard-maven-plugin is much older.

I did a quick test by changing the dependency of maven-archiver to 3.5.0 but this leads to compile errors and more deprecated code.

[lasselindqvist]

Did you test this with an empty filter and no filter parameter as well?

[nicymike]

Yes, tested without filter and with empty filter, which will be also set to null. I do not add includes/excludes on null.

[nicymike]

Thank you for merging. When do you plan to do the next release? I need this change for one of my projects.
Also release 2.3.0 is not visible on GitHub.

[lasselindqvist]

Planning to release this week with #115

I'll add both releases to Github as well. Not sure if people use those for anything though, maybe Ant users?

[nicymike]

I'm using GitHub release notifications on some projects to be informed about new versions. This is really useful as I don't need to check versions manually.