Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proguard7 fix #111

Merged
merged 4 commits into from
Aug 5, 2020
Merged

Proguard7 fix #111

merged 4 commits into from
Aug 5, 2020

Conversation

MarcMil
Copy link

@MarcMil MarcMil commented Jul 8, 2020

Proguard 7 requires two JARs on the classpath: proguard-base and proguard-core.

@lasselindqvist
Copy link
Collaborator

How did you test this? Do you have a public example project for testing?

@MarcMil
Copy link
Author

MarcMil commented Jul 9, 2020

We are using our own internal projects, but I've created a small sample project which does not work without this merge request:
https://github.com/MarcMil/proguard7-maven-sample

The reason being that both proguard-core and proguard-base must be present in the class path (opposed to only one Jar in the past).

@lasselindqvist lasselindqvist merged commit 72eb0db into wvengen:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants