-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECURITY] Use HTTPS to resolve dependencies in Maven Build #927
base: master
Are you sure you want to change the base?
[SECURITY] Use HTTPS to resolve dependencies in Maven Build #927
Conversation
This fixes a security vulnerability in this project where the `pom.xml` files were configuring Maven to resolve dependencies over HTTP instead of HTTPS. Signed-off-by: Jonathan Leitschuh <[email protected]>
This issue has been automatically marked as stale because it has not had recent activity. |
Not for lack of trying |
This issue has been automatically marked as stale because it has not had recent activity. |
Hi! This should still be merged. |
This issue has been automatically marked as stale because it has not had recent activity. |
Not stale. Still here. |
This issue has been automatically marked as stale because it has not had recent activity. |
👋 Hi. This should be merged. |
This issue has been automatically marked as stale because it has not had recent activity. |
Boo! 👻 |
This issue has been automatically marked as stale because it has not had recent activity. |
Shoo! |
This issue has been automatically marked as stale because it has not had recent activity. |
Not stale |
Boo! 👻 |
This issue has been automatically marked as stale because it has not had recent activity. |
@Stale Shoo! |
This issue has been automatically marked as stale because it has not had recent activity. |
Nope |
This issue has been automatically marked as stale because it has not had recent activity. |
Go away @Stale |
This issue has been automatically marked as stale because it has not had recent activity. |
Good lord, this is kinda getting annoying. |
This issue has been automatically marked as stale because it has not had recent activity. |
Shoo! |
This issue has been automatically marked as stale because it has not had recent activity. |
Go away! |
This issue has been automatically marked as stale because it has not had recent activity. |
Shoo |
This is a security fix for a vulnerability in your Apache Maven
pom.xml
file(s).The build files indicate that this project is resolving dependencies over HTTP instead of HTTPS.
This leaves your build vulnerable to allowing a Man in the Middle (MITM) attackers to execute arbitrary code on your or your computer or CI/CD system.
This vulnerability has a CVSS v3.0 Base Score of 8.1/10.
POC code has existed since 2014 to maliciously compromise a JAR file in-flight.
MITM attacks against HTTP are increasingly common, for example Comcast is known to have done it to their own users.
This contribution is a part of a submission to the GitHub Security Lab Bug Bounty program.
Detecting this and Future Vulnerabilities
This vulnerability was automatically detected by LGTM.com using this CodeQL Query.
As of September 2019 LGTM.com and Semmle are officially a part of GitHub.
You can automatically detect future vulnerabilities like this by enabling the free (for open-source) LGTM App.
I'm not an employee of GitHub nor of Semmle, I'm simply a user of LGTM.com and an open-source security researcher.
Source
Yes, this contribution was automatically generated, however, the code to generate this PR was lovingly hand crafted to bring this security fix to your repository.
The source code that generated and submitted this PR can be found here:
JLLeitschuh/bulk-security-pr-generator
Opting-Out
If you'd like to opt-out of future automated security vulnerability fixes like this, please consider adding a file called
.github/GH-ROBOTS.txt
to your repository with the line:This bot will respect the ROBOTS.txt format for future contributions.
Alternatively, if this project is no longer actively maintained, consider archiving the repository.
CLA Requirements
This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.
It is unlikely that I'll be able to directly sign CLAs. However, all contributed commits are already automatically signed-off.
If signing your organization's CLA is a strict-requirement for merging this contribution, please feel free to close this PR.
Tracking
All PR's generated as part of this fix are tracked here:
JLLeitschuh/bulk-security-pr-generator#2