Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the AKS-Generic Module to support Terraform 3.x.x #124

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

PubudU99
Copy link
Contributor

@PubudU99 PubudU99 commented Dec 6, 2024

Purpose

$subject

Goals

This will fix errors when using the AKS-Generic module with Terraform version >= 3.0.0

Information about the changes

Updated Parameters

  • Removed source_port_range, destination_port_range, source_address_prefix and destination_address_prefix from NSG rules as they conflict with their plural parameters - Reference
  • node_public_ip_enabled - Reference
  • auto_scaling_enabled - Reference
  • private_endpoint_network_policies - Reference
    • Possible values are ["Disabled", "Enabled", "NetworkSecurityGroupEnabled", "RouteTableEnabled"]

Deprecated or removed parameters

  • Docker Bridge CIDR - Reference
  • azure_active_directory_role_based_access_control managed property - Reference
  • api_server_authorized_ip_ranges - Reference

Security checks

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2024

CLA assistant check
All committers have signed the CLA.

VimukthiPerera
VimukthiPerera previously approved these changes Dec 9, 2024
vnet_subnet_id = azurerm_subnet.aks_node_pool_subnet.id
max_count = var.default_node_pool_max_count
min_count = var.default_node_pool_min_count
max_pods = var.default_node_pool_max_pods
orchestrator_version = var.default_node_pool_orchestrator_version
enable_node_public_ip = false
node_public_ip_enabled = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we assign this to a variable and set the default value to false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, Will do that @ayeshajay.

@VimukthiPerera VimukthiPerera merged commit 2a6939c into wso2:main Dec 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants