Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page reload support added for Waiter #8

Merged
merged 1 commit into from
Mar 20, 2014
Merged

Conversation

Slike9
Copy link
Contributor

@Slike9 Slike9 commented Jan 22, 2014

Timeout was raised when page reloaded on waiting

Timeout was raised when page reloaded on waiting
@Slike9
Copy link
Contributor Author

Slike9 commented Jan 22, 2014

Maybe, the pull request is related to issue #3 .

@ericmhalvorsen
Copy link

👍 This fix would help our test suite, currently we have hacked around this using the sleep function

@axlekb
Copy link

axlekb commented Mar 18, 2014

👍 I tested this branch to resolve an issue in one of our tests.

Any chance this will ever get merged?

wrozka added a commit that referenced this pull request Mar 20, 2014
Page reload support added for Waiter
@wrozka wrozka merged commit ef7184a into wrozka:master Mar 20, 2014
@wrozka
Copy link
Owner

wrozka commented Mar 20, 2014

Thanks for the patch, sorry you have waited so long for the merge, I still need to figure out a way to automatically test this gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants