Add commands for managing signups on multisite

[ernilambar]

Adds signup command and subcommands

• signup list
• signup activate
• signup get
• signup delete

Command details: https://github.com/ernilambar/entity-command/tree/feat-signup#wp-signup

Related: wp-cli/wp-cli#1911

PR inspired from https://github.com/trepmal/wp-cli-unconfirmed-users

Highlights:

• Separate Signup Fetcher is used here
• Better signup validation using $this->fetcher->get_check()
• Command class extends CommandWithDBObject which provides several helpful methods

[tyrann0us]

Thank you very much for working on this! I left some nit-picky comments that try aligning wording as close to existing commands as possible.
If you agree with my comments in README.md, please also apply them to src/Signup_Command.php. Thank you!
Also, I would have expected that there would be WordPress APIs (PHP functions) for fetching and deleting signups, but I couldn't find anything. 🤷🏽

[ernilambar]

Note:

• Fetcher should be probably moved to https://github.com/wp-cli/wp-cli/tree/main/php/WP_CLI/Fetchers

[tyrann0us]

Thanks for incorporating all the changes. 🙏🏽
Would it be possible to add tests for failed activating and deleting signups to ensure the presence of the "Failed (activating|deleting) signup 123" message?

Fetcher should be probably moved to https://github.com/wp-cli/wp-cli/tree/main/php/WP_CLI/Fetchers

Does it make sense to create a separate PR there, have it merged, and then continue here?

[tyrann0us]

I left another round of nit-picky wording-related comments. However, these don't stop me from approving.
Thank you for working on this! It's a small feature, but we have desperately wanted it at times. 💚

[tyrann0us]

Hi @danielbachhuber, to continue our conversation from wp-cli/wp-cli#1911, would you consider this PR ready? Thanks!

[danielbachhuber]

Great start! I left some comments.

[swissspidy]

@ernilambar I just merged wp-cli/wp-cli#5926 now

To make the PR work now, update composer.json here to require "wp-cli/wp-cli": "^2.11"

[swissspidy]

I don't understand the test failures, they look unrelated 🤔

[ernilambar]

I don't understand the test failures, they look unrelated 🤔

Yah, there are no changes related to taxonomies here.

[swissspidy]

Ah, when I try locally I get this:

$ WP_VERSION=trunk composer behat features/taxonomy.feature:7
> run-behat-tests 'features/taxonomy.feature:7'
-----

--- Failed hooks:

    BeforeSuite # WP_CLI\Tests\Context\FeatureContext::prepare()
      $ wp cli info
      
      Error: Callable "Signup_Command" does not exist, and cannot be registered as `wp user signup`.
      cwd: 
      run time: 0.16830706596375
      exit status: 1 (RuntimeException)

Edit: just needed to run composer update

[swissspidy]

As just discussed on the Zoom call, it's because of wp-cli/wp-cli#5928

We'll fix this separately.

[swissspidy]

wp-cli/wp-cli#5928 has been reverted in the meantime

[johnbillion]

See also wp-cli/ideas#99

[danielbachhuber]

@ernilambar Can you:

1. Credit the original package in the PR description?
2. Highlight any differences between this implementation and the original package?

Feedback has been addressed