Support emails in user_login field #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logins can be set to e-mails, and are often set this way. This is fine, until the user changes the e-mail (logins can't be changed). What happens then? `wp user get` doesn't find the user by login, because if the login is an e-mail it shorts to checking only the user_email field. Rectify this. Tests included.
danielbachhuber
approved these changes
Jun 29, 2017
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logins can be set to e-mails, and are often set this way. This is fine,
until the user changes the e-mail (logins can't be changed). What
happens then?
wp user getdoesn't find the user by login, because ifthe login is an e-mail it shorts to checking only the user_email field.
Rectify this. Tests included.