Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Folders for Authenticator #23743

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Conversation

jkmassel
Copy link
Contributor

Similarly to #23736, this PR cleans up a bunch of the project file by moving WPAuthenticator inside the project directory and converting it to a folder-based hierarchy.

To test

  • Ensure that CI passes and that the WPAuthenticator tests run

@dangermattic
Copy link
Collaborator

3 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23743-831c2ee
Version25.4.2
Bundle IDorg.wordpress.alpha
Commit831c2ee
App Center BuildWPiOS - One-Offs #10935
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23743-831c2ee
Version25.4.2
Bundle IDcom.jetpack.alpha
Commit831c2ee
App Center Buildjetpack-installable-builds #9975
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkmassel jkmassel added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2024
@jkmassel jkmassel added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2024
@jkmassel jkmassel added this pull request to the merge queue Oct 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 31, 2024
@wpmobilebot wpmobilebot modified the milestones: 25.5, 25.6 Dec 5, 2024
@wpmobilebot
Copy link
Contributor

Version 25.5 has now entered code-freeze, so the milestone of this PR has been updated to 25.6.

@kean
Copy link
Contributor

kean commented Dec 9, 2024

Hey, looks like it has a few conflicts now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants