Frist Delivery #43
Open
Frist Delivery #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2023 17:03
mrarrieta
reviewed
Feb 6, 2023
| android:padding="16dp" | ||
| android:orientation="vertical"> | ||
|
|
||
| <ImageView |
| app:layout_constraintTop_toTopOf="parent"/> | ||
|
|
||
| <TextView | ||
| android:id="@+id/txt_MinimumPrice" |
There was a problem hiding this comment.
usa cammel case o snake case en los nombres de los ids pero debes ser consistente.
| import android.net.ConnectivityManager | ||
|
|
||
| object BaseUtils { | ||
| var context: Context? = null |
| ): View? { | ||
| _binding = FragmentCryptoListBinding.inflate(inflater, container, false) | ||
| val view = binding.root | ||
| return view } |
| } | ||
|
|
||
| cryptoViewModel.onCreateTicker(bookName) | ||
| cryptoViewModel.tickerState.observe(viewLifecycleOwner) { |
There was a problem hiding this comment.
Puedes tener 1 solo Live data si emites estados distintos con la informacion necesaria
| ){ | ||
| suspend operator fun invoke(): List<BooksModelDomain> { | ||
| val books = cryptoRepository.getAllAvailableBooksFromApi() | ||
| return if (books.isNotEmpty()) { |
There was a problem hiding this comment.
el use case debe capturar las excepciones
| suspend operator fun invoke(book: String): List<AsksModelDomain> { | ||
| val asks = cryptoRepository.getAllAsksFromApi(book) | ||
|
|
||
| return if (asks.isNotEmpty()) { |
There was a problem hiding this comment.
el use case debe capturar las excepciones
| import kotlinx.coroutines.withContext | ||
| import javax.inject.Inject | ||
|
|
||
| class CryptoService @Inject constructor( |
There was a problem hiding this comment.
creo que CryptoRemoteDataSource es mas claro como nombre
| import com.jpgl.cryptocurrencies.domain.model.* | ||
| import javax.inject.Inject | ||
|
|
||
| class CryptoRepository @Inject constructor( |
There was a problem hiding this comment.
el use case no deberia saber si esta consumiendo la informacion desde un api o desde una base de datos local, se supone que el repo abstrae todo esto, no lo expone.
| import retrofit2.converter.gson.GsonConverterFactory | ||
|
|
||
| object RetrofitConfig { | ||
| fun getConfigRetrofit(): Retrofit { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Setup
-Navigation
-Dependency Injection
-Retrofit adapter and dependency injection.
-MVVM
-Add visual items