Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tvOS #4763

Closed
wants to merge 1 commit into from
Closed

Conversation

hufkens
Copy link

@hufkens hufkens commented Feb 19, 2019

What this PR does?

We want to use react-native-navigation for our TV Apps. Other navigation solutions don't work that well and we want the native feel. Also react-native is dropping TabBarIOS and NavigatorIOS from the core. So we need a good navigation library that we can use on al platforms.

What has changed

I added a target ReactNativeNavigation-tvOS to that builds to the tvOS SDK. This means I had to exclude not supported code using compiler flags.

Opinions?

Tell me what do you guys think? It's a start and a work in progress, and I hope that you are interested to give some feedback. We are intending to use it in our apps (iOS, Android, tvOS, Android TV).

To Do

I need to find a way to hook the Menu gesture handler, so that it will pop() the Screen until the last one and then exit the app.

@guyca
Copy link
Collaborator

guyca commented Feb 28, 2019

Hey @hufkens, Looks very promising! You're welcome to ping me on discord if you need anything on our end 👍

@hufkens
Copy link
Author

hufkens commented Mar 1, 2019

@guyca We were looking into using react-native-navigation for our TV apps. I managed to get it functionally working. But we stopped working on it because of this issue #4485

We also need the TopTabs to be working but they seem to be broken now.

There are also still 2 open issues:

  • Correctly handle the "menu" button on tvOS. Pressing the menu should go back in the UINavigationController and/or close a Modal.
  • The Splash screen logic now works with the xib, but there are no xibs on Apple TV. That code is commented for now and there is no splash screen shown.

I have an account on discord but don't use it that much.

@hufkens hufkens changed the title [WIP] Add support for tvOS Add support for tvOS Mar 1, 2019
@guyca
Copy link
Collaborator

guyca commented Mar 17, 2019

Thanks for the update, perhaps someone will pick this up in the future 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants