Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Add tvOS support #2012

Closed
wants to merge 3 commits into from
Closed

[v2] Add tvOS support #2012

wants to merge 3 commits into from

Conversation

neilkimmett
Copy link

Some UIKit classes aren't available on tvOS (they're marked with __TVOS_PROHIBITED in the framework headers) so in order to build for tvOS we need to conditionally compile out any references to them. Also adds a tvOS library target in the Xcode project.

@neilkimmett
Copy link
Author

Error from CI is

/usr/local/Homebrew/Library/Homebrew/brew.rb:12:in `<main>': Homebrew must be run under Ruby 2.3! (RuntimeError)
Error: No available formula with the name "applesimutils" 
==> Searching for a previously deleted formula...
Warning: homebrew/core is shallow clone. To get complete history run:
  git -C "$(brew --repo homebrew/core)" fetch --unshallow
Error: No previously deleted formula found.
==> Searching for similarly named formulae...
==> Searching local taps...
Error: No similarly named formulae found.
==> Searching taps...
==> Searching taps on GitHub...
Error: No formulae found in taps.
The command "source ./scripts/env/installAppleSimUtils.sh" failed and exited with 1 during .

which doesn't seem like its related to my change.

#if !(TARGET_OS_TV)
CGFloat systemFontSize = [UIFont systemFontSize];
#else
CGFloat systemFontSize = 20;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth pointing out I've plucked this default value out of thin air; tvOS doesn't have a systemFontSize.

@neilkimmett neilkimmett changed the title Add tvOS support to v2 [v2] Add tvOS support Oct 12, 2017
@guyca guyca added the v2 label Oct 17, 2017
@DanielZlotin DanielZlotin requested a review from gran33 October 22, 2017 08:00
@gregorymfoster
Copy link

Looks like this is failing hides Tab Bar when pressing on Hide Top Bar and shows it when pressing on Show Top Bar, perhaps because the tvos does not support this functionality. Maybe we could modify some of the existing tests to skip the tvos target?

@gran33 What can we do to get this merged into the main repository?

@psegalen
Copy link

psegalen commented Mar 7, 2018

If someone could merge this, it would be great! 🙏

@yershalom
Copy link
Contributor

Can one of the admins verify this patch?

@stale
Copy link

stale bot commented Jun 2, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Jun 2, 2018
@stale
Copy link

stale bot commented Jun 9, 2018

The issue has been closed for inactivity.

@stale stale bot closed this Jun 9, 2018
@itsmepetrov
Copy link

Hi @neilkimmett, do you have any plans to continue working on tvOS support? I would like to help you with it.

@neilkimmett
Copy link
Author

@itsmepetrov hey alas I don't work on that app anymore, and we didn't even end up using this library, we used https://facebook.github.io/react-native/docs/tabbarios. I can help you with any questions you have tho. I gave a talk about that work last year which you might find useful http://kimmett.me/talks/react-native-on-tvos.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants