-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] Add tvOS support #2012
[v2] Add tvOS support #2012
Conversation
Error from CI is
which doesn't seem like its related to my change. |
#if !(TARGET_OS_TV) | ||
CGFloat systemFontSize = [UIFont systemFontSize]; | ||
#else | ||
CGFloat systemFontSize = 20; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth pointing out I've plucked this default value out of thin air; tvOS doesn't have a systemFontSize
.
Looks like this is failing @gran33 What can we do to get this merged into the main repository? |
If someone could merge this, it would be great! 🙏 |
Can one of the admins verify this patch? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
The issue has been closed for inactivity. |
Hi @neilkimmett, do you have any plans to continue working on tvOS support? I would like to help you with it. |
@itsmepetrov hey alas I don't work on that app anymore, and we didn't even end up using this library, we used https://facebook.github.io/react-native/docs/tabbarios. I can help you with any questions you have tho. I gave a talk about that work last year which you might find useful http://kimmett.me/talks/react-native-on-tvos.html |
Some UIKit classes aren't available on tvOS (they're marked with
__TVOS_PROHIBITED
in the framework headers) so in order to build for tvOS we need to conditionally compile out any references to them. Also adds a tvOS library target in the Xcode project.