-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: undeprecate "specs" in package.json #1290
Conversation
Any luck finding why it showed an unrelated error when specs was not provided? |
@LeoNatan, yes, it was a bug in |
@LeoNatan, as far as I understand, it is a synergy of those pull requests that resolved the weird error: mochajs/mocha#3650 The mocha contributors have fixed a lot of command-line interface errors, as can be seen in their CHANGELOG. |
Description:
In
[email protected]
there was a premature deprecation of"specs"
property in detox section ofpackage.json
. It appeared inconvenient for anyone who prefers terse commands likedetox test
over verbosedetox test e2e
. From now on, "specs" property will act as a fallback if a specific test folder has not been specified. For example (1):For the reference, previously it used to work like (2):
The problem of the latter was that you could not focus (override defaults) on a specific test file without having to use
specs
in package.json and deprecated--specs
in the command line (3):Since (2) has been introduced very recently and did not function well, I suggest to consider this rather a minor version than a breaking change.
Your considerations are welcome.
P. S. As for
file
deprecation warning, it has been reworked and looks like on the screenshot: