Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugs #80

Merged
merged 18 commits into from
Oct 25, 2023
Merged

fix: bugs #80

merged 18 commits into from
Oct 25, 2023

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Oct 25, 2023

Description of change

  • feat: adapt to the latest llama.cpp interface
  • feat: print helpful information to help resolve a clone issue when it happens
  • feat: print helpful information to help resolve build issues related to CUDA
  • feat: make portable cmake on Windows more stable
  • feat: update CMakeLists.txt to match llama.cpp better
  • fix: do not download redundant node headers
  • fix: improve cmake custom options handling
  • fix: do not set CMAKE_GENERATOR_TOOLSET for CUDA
  • fix: do not fetch information from GitHub when using a local git bundle
  • fix: GBNF JSON schema string const formatting
  • docs: document a solution to a compilation problem on macOS
  • docs: document more CUDA build error solutions
  • docs: explain about ES modules in the getting started guide
  • chore: update .commitlintrc.json
  • chore: remove redundant dependency

Fixes #78
Fixes #79
Fixes #58
Reintroduces #74 - added documentation on how to resolve it (link)

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto October 25, 2023 21:02
@giladgd giladgd self-assigned this Oct 25, 2023
Copy link
Contributor

@ido-pluto ido-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd giladgd enabled auto-merge (squash) October 25, 2023 22:44
@giladgd giladgd merged commit ff1644d into master Oct 25, 2023
11 checks passed
@giladgd giladgd deleted the gilad/bugFixes branch October 25, 2023 22:45
@github-actions
Copy link

🎉 This PR is included in version 2.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants