Allow file URLs to be used as import specifiers

[matthewp]

Changes

• Wanted to support this pattern in integrations: addDevToolbarApp(new URL('./plugin.ts', import.meta.url))
• This doesn't currently work because we directly pass this value into the virtual module.
• Vite does not support file URLs.
• A Vite plugin is the answer! Maybe we can talk them into adding this to core.

Testing

• Test added

Docs

N/A, bug fix

[changeset-bot]

🦋 Changeset detected

Latest commit: 5fe9955

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[natemoo-re]

I'm not sure how I feel about this... seems like integration hooks should handle conversions from whatever formats we want to support for entrypoints into a valid ID for Vite.

[matthewp]

@natemoo-re I thought about doing it that way, but this is a lower-level solution and enables any vite plugin (in Astro) to use file URLs which is a super convenient way to support this sort of pattern (having some config value that gets piped into a virtual module). So I felt that was better.

We already allow full file paths as module specifiers, why not file URLs? It's the same thing, but more universal.

[natemoo-re]

I'm okay with supporting this! Still think we should fix the inconsistent integration entrypoint support, but that can be a follow-up

[matthewp]

@natemoo-re can you explain more? Which integration APIs are inconsistent? I can maybe fix it up here. I just did a quick scan and it looks like all of them save what is passed in directly. Maybe they mutate it further down the stack?

[lilnasy]

Works well, simplifies things. Looks great to me!

[natemoo-re]

@natemoo-re can you explain more? Which integration APIs are inconsistent? I can maybe fix it up here. I just did a quick scan and it looks like all of them save what is passed in directly. Maybe they mutate it further down the stack?

IMO that's the inconsistency? Some of them throw helpful errors if they can't resolve the file, some of them don't. Some of them support URL because they convert it to a path before storing it, some of them don't. Some support relative specifiers, some don't. My thought was to have a util that would normalize them or some way to ensure that they're all stored as a valid Vite ID.

[matthewp]

@natemoo-re Do you know which ones behave differently? From looking at the code I don't see a difference.