Support Vue JSX #4897
Merged
Support Vue JSX #4897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6aedbea The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
matthewp
approved these changes
Sep 28, 2022
|
Fixed the intellisense issue. Good to go once I get docs approval! |
matthewp
approved these changes
Sep 28, 2022
Jutanium
reviewed
Sep 28, 2022
Jutanium
reviewed
Sep 28, 2022
|
I think it would be good to show an example of passing options instead of a boolean, as the linked docs are slightly different (there the options are passed directly to the plugin, whereas here they're passed to the |
Co-authored-by: Dan Jutan <[email protected]>
Co-authored-by: Dan Jutan <[email protected]>
|
Added an example to show passing options! 766ade7 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Close #4450
Introduce
jsx: booleanoption for@astrojs/vue. If true, it would add two renderers for .vue and .jsx files.I'm not sure if there's a way to combine that like preact compat does.
Testing
added a vue jsx test
Docs
Documented in the readme.