Improve nested and client:only hydration
#3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 00ccc48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
⚖️ Bundle Size CheckLatest commit: ee3ee55
|
github-actions
bot
added
pkg: solid
1 task
natemoo-re
force-pushed
the
fix/nested-islands
branch
from
7199208 to
72373b1
Compare
natemoo-re
changed the title
client:only hydrationclient:only hydration
matthewp
reviewed
May 27, 2022
|
Co-authored-by: Matthew Phillips <[email protected]>
natemoo-re
force-pushed
the
fix/nested-islands
branch
from
368d375 to
0a78562
Compare
Closed
added 3 commits
May 27, 2022 14:51
1 task
tony-sull
approved these changes
May 31, 2022
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* wip: fix nested islands * fix: improve hydration for dynamic content * chore: fix bundle-size script for new files * chore: allow-list client:* directive files * fix(withastro#3362): fix client:only behavior for React, Vue, Solid * test: add client-only e2e test * chore: update lockfile * test: fix e2e tests * test: add framework nesting e2e tests * Update packages/astro/src/runtime/client/events.ts Co-authored-by: Matthew Phillips <[email protected]> * chore: add changeset * fix(preact): ignore hydrate roots * chore: remove `ssr` check in integrations * Revert "chore: remove `ssr` check in integrations" This reverts commit ba27eaa. * chore: add changeset Co-authored-by: Matthew Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
client:onlyerrors @ React, Vue, & Solid #3362MutationObserver(if available) to check for any unhydrated roots, meaning islands nested in other islands should now be stableTesting
client:onlye2e testDocs
N/A