chore: better warning #12642
Merged
chore: better warning #12642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 29cc5c4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #12642 will not alter performanceComparing Summary
|
sarah11918
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Just happened to see this, and server-rendered has a hyphen so I threw one in there and will give you an approval from docs, fwiw!
(Very clear and descriptive changeset message! I'm always so proud of everyone that we take the time to write something helpful there.)
Co-authored-by: Sarah Rainsberger <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the
routePatternto the warning aboutAstro.request.headersbeing used in pre-rendered pages.This should give us better information when debugging the annoying warning :)
Testing
CI should pass
Docs
N/A