Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't apply duplicate class to images #12631

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: don't apply duplicate class to images #12631

merged 2 commits into from
Dec 4, 2024

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Dec 4, 2024

Changes

Fixes a bug where the class attribute was rendered twice on images during builds

Fixes #12629

Testing

Adds more tests for images during build, including tests of the raw HTML without cheerio

Docs

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: dc8c4eb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: dc8c4eb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 4, 2024
@ascorbic ascorbic merged commit dec0305 into main Dec 4, 2024
16 of 22 checks passed
@ascorbic ascorbic deleted the dedupe-img-class branch December 4, 2024 18:26
@astrobot-houston astrobot-houston mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image class attribute is duplicated
3 participants