-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix custom assetFileNames
issue
#12449
fix custom assetFileNames
issue
#12449
Conversation
|
CodSpeed Performance ReportMerging #12449 will improve performances by 19.02%Comparing Summary
Benchmarks breakdown
|
0ad5f7b
to
d452c63
Compare
assetFileNames
issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @apatel369, sorry for the late review. The fix looks good, I would suggest a better description for merging the PR
improve changeset
Changes
closes #426 in adapters repo
When using custom
assetFileNames
in Astro configuration assets were incorrectly moved to the server directory instead of the client directory. This caused 404 errors when the browser tried to load these assets from the client side.Users could specify custom directories for various asset types (e.g., CSS, images). To handle that used asset paths from the build output to ensure assets are moved from/to the correct directories.
Testing
Added tests for testing image and CSS assets with custom paths.
The previous test was passing cause accidentally
build.assets
and customassetFileNames
path were matching.(
assets
and assets/css)So updated that as well.
Docs
N/A bug fix