Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add defineIntegration utility #10892

Closed
wants to merge 18 commits into from
Closed

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Apr 26, 2024

Changes

  • Adds a new defineIntegration helper
  • Updates how Astro DB extend hooks types

Testing

Tests should still pass, added a unit test

Docs

withastro/docs#8056

Copy link

changeset-bot bot commented Apr 26, 2024

🦋 Changeset detected

Latest commit: b60b5fd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Apr 26, 2024
@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label Apr 29, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@florian-lefebvre florian-lefebvre marked this pull request as ready for review April 30, 2024 17:12
@matthewp
Copy link
Contributor

Great job! I think I have a few opinions on the API shape but we can follow up on that. Reminder that to get this merged we'll need:

  1. Promote your RFC to stage 2.
  2. Have a stage 3 RFC PR.
  3. Under an experimental flag (unless we decide experimental is not needed).

We can do (1) through an RFC meeting. Would you be available to come to a future community call to present the stage 1 and see if we have consensus to move? If you can't (I know it's a little later for you), we can set up a special RFC call for this.

@florian-lefebvre
Copy link
Member Author

My bad I was too happy to avoid getting this stale so completely forgot about the RFC process, setting back to draft for now

@florian-lefebvre florian-lefebvre marked this pull request as draft May 1, 2024 06:48
@florian-lefebvre florian-lefebvre removed this from the 4.8.0 milestone May 1, 2024
@florian-lefebvre florian-lefebvre added the needs discussion Issue needs to be discussed label May 28, 2024
@florian-lefebvre
Copy link
Member Author

There's still no consensus on this for now, so I'm closing it until we want to revisit. RFC at withastro/roadmap#886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Issue needs to be discussed pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants