-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add defineIntegration utility #10892
Conversation
🦋 Changeset detectedLatest commit: b60b5fd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
Great job! I think I have a few opinions on the API shape but we can follow up on that. Reminder that to get this merged we'll need:
We can do (1) through an RFC meeting. Would you be available to come to a future community call to present the stage 1 and see if we have consensus to move? If you can't (I know it's a little later for you), we can set up a special RFC call for this. |
My bad I was too happy to avoid getting this stale so completely forgot about the RFC process, setting back to draft for now |
There's still no consensus on this for now, so I'm closing it until we want to revisit. RFC at withastro/roadmap#886 |
Changes
defineIntegration
helperTesting
Tests should still pass, added a unit test
Docs
withastro/docs#8056