fix(upgrade): verify astro installation before upgrade to prevent f…

…alse success (#12576)
withastro · Dec 4, 2024 · 19b3ac0 · 19b3ac0
1 parent 44af543
commit 19b3ac0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/.changeset/little-rules-relate.md b/.changeset/little-rules-relate.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/upgrade': patch
+---
+
+Fixes an issue where running `upgrade` in a directory without `astro` installed shows a false success message
diff --git a/packages/upgrade/src/actions/verify.ts b/packages/upgrade/src/actions/verify.ts
@@ -24,7 +24,13 @@ export async function verify(
 		}
 	}
 
-	await verifyAstroProject(ctx);
+	const isAstroProject = await verifyAstroProject(ctx);
+	if (!isAstroProject) {
+		bannerAbort();
+		newline();
+		error('error', `Astro installation not found in the current directory.`);
+		ctx.exit(1);
+	}
 
 	const ok = await verifyVersions(ctx, registry);
 	if (!ok) {