ES6: migrated "client" #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipis
approved these changes
Mar 31, 2017
gregor
reviewed
Mar 31, 2017
app/script/client/ClientMapper.js
Outdated
| window.z.client = z.client || {}; | ||
|
|
||
| z.client.ClientMapper = class ClientMapper { | ||
|
|
gregor
suggested changes
Mar 31, 2017
| .then(clients => { | ||
| return clients | ||
| .filter((client) => (z.client.Client.dismantle_user_client_id(client.meta.primary_key)).user_id === user_id) | ||
| .map((client) => client); |
lipis
reviewed
Mar 31, 2017
app/script/client/ClientMapper.js
Outdated
| z.client.ClientMapper = class ClientMapper { | ||
|
|
||
| constructor() { | ||
| } |
There was a problem hiding this comment.
do we need an empty constructor?
lipis
reviewed
Apr 5, 2017
app/script/client/ClientService.js
Outdated
| return this.client.send_json({ | ||
| url: this.client.create_url(`${z.client.ClientService.URL_CLIENTS}/${client_id}`), | ||
| type: 'DELETE', | ||
| data: {}}); |
There was a problem hiding this comment.
return this.client.send_json({
url: this.client.create_url(`${z.client.ClientService.URL_CLIENTS}/${client_id}`),
type: 'DELETE',
data: {},
});
lipis
reviewed
Apr 5, 2017
| device_model = `${device_model} (Internal)`; | ||
| } | ||
| } else { | ||
| if (client_type === z.client.ClientType.TEMPORARY) { |
lipis
approved these changes
Apr 5, 2017
bennycode
approved these changes
Apr 5, 2017
lipis
reviewed
Apr 5, 2017
| return this.client_service.load_all_clients_from_db() | ||
| .then(clients => { | ||
| return clients.filter((client) => { | ||
| return (z.client.Client.dismantle_user_client_id(client.meta.primary_key)).user_id === user_id |
lipis
approved these changes
Apr 6, 2017
herrmannplatz
pushed a commit
that referenced
this pull request
Apr 6, 2017
This reverts commit bf3b69t d3b3d8b2180c47fd0b25fe0fe405f7c63e.
herrmannplatz
pushed a commit
that referenced
this pull request
Apr 6, 2017
This reverts commit 1f08296.
herrmannplatz
added a commit
that referenced
this pull request
Apr 10, 2017
herrmannplatz
pushed a commit
that referenced
this pull request
Apr 10, 2017
This reverts commit bf3b69t d3b3d8b2180c47fd0b25fe0fe405f7c63e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.