ES6: Migrate "audio" with proper logging #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipis
reviewed
Mar 21, 2017
app/script/audio/AudioRepository.js
Outdated
| else if (this.audio_preference() === z.audio.AudioPreference.SOME && !(z.audio.AudioPlayingType.SOME.includes(audio_id))) { | ||
| reject(new z.audio.AudioError(z.audio.AudioError.prototype.TYPE.IGNORED_SOUND)); | ||
| } | ||
| else { |
There was a problem hiding this comment.
http://eslint.org/docs/rules/brace-style we should have the 1tbs :)
if (...) {
...
} else if (...) {
...
} else {
...
}There was a problem hiding this comment.
As long as it can be done automatically, I am fine with it. :-)
herrmannplatz
approved these changes
Mar 21, 2017
app/script/audio/AudioError.js
Outdated
|
|
||
| (function() { | ||
| function AudioError(type) { | ||
| this.name = this.constructor.name; |
There was a problem hiding this comment.
cant we use es6 classes here?
app/script/audio/AudioRepository.js
Outdated
| 'use strict'; | ||
|
|
||
| (function() { | ||
| window.z = window.z || {}; |
There was a problem hiding this comment.
u can remove the self executing fucntion
lipis
reviewed
Mar 21, 2017
| @@ -13,6 +13,7 @@ globals: | |||
| z: true | |||
|
|
|||
| rules: | |||
| brace-style: [2, 1tbs] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Screenshot