ES6: Migrated "assets" #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
herrmannplatz
commented
Mar 17, 2017
•
herrmannplatz
commented
- fix test
- update comments
lipis
reviewed
Mar 17, 2017
| return this._build_image_metdadata(file); | ||
| } else { | ||
| return Promise.resolve(); | ||
| } |
There was a problem hiding this comment.
I'm no fan of single line if statements.. but applies nicely here:
if (this.is_video(file)) return this._build_video_metdadata(file);
if (this.is_audio(file)) return this._build_audio_metdadata(file);
if (this.is_image(file)) return this._build_image_metdadata(file);
return Promise.resolve();
There was a problem hiding this comment.
But but but... #consistency
There was a problem hiding this comment.
like I said.. already.. I'm not a big fan of it..! So I won't mind if not changed :)
lipis
reviewed
Mar 17, 2017
app/script/assets/AssetService.js
Outdated
| return resolve(JSON.parse(this.response)); | ||
| } else { | ||
| return reject(event); | ||
| } |
There was a problem hiding this comment.
if (this.status === 201) {
return resolve(JSON.parse(this.response));
}
return reject(event);
lipis
reviewed
Mar 17, 2017
|
|
||
| z.assets.AssetUploadFailedReason = { | ||
| FAILED: 1, | ||
| CANCELLED: 0, |
lipis
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.