Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MomentSpec.js #895

Merged
merged 4 commits into from
Mar 15, 2017
Merged

MomentSpec.js #895

merged 4 commits into from
Mar 15, 2017

Conversation

lipis
Copy link
Contributor

@lipis lipis commented Mar 15, 2017 •
edited
Loading

What do we do with those errors?

screen shot 2017-03-15 at 2 18 42 pm

Related #891

@bennycode
Copy link
Contributor

bennycode commented Mar 15, 2017 •
edited
Loading

@lipis:

Use the global form of 'use-strict'. (strict)

Just put use-strict on top of the file

'describe' is not defined. (no-undef)

You need to define the function as a JS comment on top of the file, like: /*global describe*/ (http://eslint.org/docs/2.0.0/rules/no-undef)

lipis added 2 commits March 15, 2017 14:33
@lipis
use strict
c167f7b
@lipis
Merge branch 'MomentSpec' of github.com:wireapp/wire-webapp into Mome…
9cb88b3 
…ntSpec

* 'MomentSpec' of github.com:wireapp/wire-webapp:
  Ensure missed call reports correct call creator (#896)
  Fixed uglify issue with ES6 syntax (#894)
@lipis lipis merged commit 27f74d7 into dev Mar 15, 2017
@bennycode bennycode deleted the MomentSpec branch March 20, 2017 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennycode bennycode bennycode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lipis @bennycode