Convert config to ES6 #888
Conversation
app/script/config.js
Outdated
| // 15 megabyte image upload limit | ||
| MAXIMUM_IMAGE_FILE_SIZE: ( | ||
| 15 * 1024 * 1024 | ||
| ), |
There was a problem hiding this comment.
MAXIMUM_ASSET_FILE_SIZE: 15 * 1024 * 1024,
app/script/config.js
Outdated
| 'image/gif', | ||
| ], | ||
|
|
||
| LOCALYTICS_SESSION_TIMEOUT: (3 * 60 * 1000), // 3 minutes in milliseconds |
app/script/config.js
Outdated
| MINIMUM_PASSWORD_LENGTH: 8, | ||
|
|
||
| // Time until phone code expires | ||
| LOGIN_CODE_EXPIRATION: (10 * 60), |
There was a problem hiding this comment.
Yes, but it makes it more readable.
app/script/config.js
Outdated
|
|
||
| 'use strict'; | ||
|
|
||
| if (window.z === null) { |
There was a problem hiding this comment.
Use == instead of === (to include undefined)
app/script/config.js
Outdated
| PURPLE: 7, | ||
| }, | ||
|
|
||
| // Conversation size |
app/script/config.js
Outdated
| // Conversation size | ||
| MAXIMUM_CONVERSATION_SIZE: 128, | ||
|
|
||
| // self profile image size |
There was a problem hiding this comment.
Why is it useless? The variable describes only a minimum profile image size, the comment explains that it is about the user's self profile image.
| // Maximum of parallel uploads | ||
| MAXIMUM_ASSET_UPLOADS: 10, | ||
|
|
||
| // Maximum characters per message |
There was a problem hiding this comment.
useless comment, the constant is self explanatory
There was a problem hiding this comment.
No, because it explains that the length is measured in characters, not in bytes or anything else.
There was a problem hiding this comment.
Then we have to update the constant to MAXIMUM_MESSAGE_CHARACTERS
There was a problem hiding this comment.
Constant renaming comes in another PR...
app/script/config.js
Outdated
| // 25 megabyte upload limit ( minus iv and padding ) | ||
| MAXIMUM_ASSET_FILE_SIZE: 25 * 1024 * 1024 - 16 - 16, | ||
|
|
||
| // Maximum of parallel uploads |
There was a problem hiding this comment.
useless comment, the constant is self explanatory
There was a problem hiding this comment.
I don't know what iv means.
There was a problem hiding this comment.
No, not self-explanatory. The variable describes only a maximum of any asset uploads, the comment describes that it is about parallel uploads.
| MINIMUM_PASSWORD_LENGTH: 8, | ||
|
|
||
| // 10 seconds until phone code expires | ||
| LOGIN_CODE_EXPIRATION: 10 * 60, |
There was a problem hiding this comment.
if it's 10 seconds.. why it's multiplied by 60?
There was a problem hiding this comment.
Usage of this code is @code_expiration_timestamp z.util.get_unix_timestamp() + z.config.LOGIN_CODE_EXPIRATION.
There was a problem hiding this comment.
It's definitely 10 minutes - comment is wrong
Type of change
Screenshot