-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES6 migrate grunt #1376
ES6 migrate grunt #1376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
grunt/config/postcss.js
Outdated
browsers: [ | ||
'Chrome >= 52', | ||
'Edge >= 14', | ||
'Firefox >= 45', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets align the numbers with the ones that actually get to access the app in one go
grunt/tasks/misc.js
Outdated
grunt.log.ok(`Version target set to ${grunt.option('target')}`); | ||
} else { | ||
target = grunt.config('gitinfo.local.branch.current.name'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is actually error prone despite having the same bug in the coffeescript implementation. We should set target to a default value of grunt.config and then we also no longer need the if but just do it.
No description provided.