ES6: Migrate 'view_model' #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregor
force-pushed
the
es6/view_model
branch
15 times, most recently
from
c43dd03 to
18886a1
Compare
gregor
force-pushed
the
es6/view_model
branch
5 times, most recently
from
1342c53 to
40d57a1
Compare
ffflorian
suggested changes
May 16, 2017
| ], | ||
| }; | ||
|
|
||
| } |
| }); | ||
| this.posted_mode_verify = ko.pureComputed(() => { | ||
| return this.posted_mode() === z.auth.AuthView.MODE.POSTED_VERIFY; | ||
| }); |
There was a problem hiding this comment.
Functions in lines 248-262 can all be replaced by the short version:
this.posted_mode_verify = ko.pureComputed(() => this.posted_mode() === z.auth.AuthView.MODE.POSTED_VERIFY);| }) | ||
| .then(() => { | ||
| return this.user_service.change_own_email(this.username()); | ||
| }) |
There was a problem hiding this comment.
Short function could be applied here, too.
| let payload = {}; | ||
| const username = this.username() | ||
| .trim() | ||
| .toLowerCase(); |
There was a problem hiding this comment.
const username = this.username().trim().toLowerCase();
There was a problem hiding this comment.
More than two.. :) it's too deep..
| this.state(GiphyViewModel.STATE.ERROR); | ||
| }); | ||
|
|
||
| } |
| let main_css_classes = `main-accent-color-${this.user().accent_id()}`; | ||
| main_css_classes += ` ${this.user().accent_theme()}`; | ||
| main_css_classes += ' show'; | ||
| return main_css_classes; |
There was a problem hiding this comment.
const main_css_classes = `main-accent-color-${this.user().accent_id()} ${this.user().accent_theme()} show';or
let main_css_classes = `main-accent-color-${this.user().accent_id()} `;
main_css_classes += this.user().accent_theme();
main_css_classes += ' show';| this.calls = this.calling_repository.calls; | ||
| this.joined_call = this.calling_repository.joined_call; | ||
|
|
||
| this.videod_call = ko.pureComputed(() => { |
There was a problem hiding this comment.
Shouldn't it be this.video_call (everywhere)?
gregor
force-pushed
the
es6/view_model
branch
2 times, most recently
from
db7c798 to
32aef09
Compare
lipis
approved these changes
May 16, 2017
ffflorian
approved these changes
May 16, 2017
gregor
force-pushed
the
es6/view_model
branch
3 times, most recently
from
43989af to
b79bacd
Compare
added 2 commits
May 16, 2017 22:29
lipis
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.