Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate 'test/unit_tests' to ES6 #1201

Merged
merged 31 commits into from
May 9, 2017
Merged

Migrate 'test/unit_tests' to ES6 #1201

merged 31 commits into from
May 9, 2017

Conversation

gregor
Copy link
Contributor

@gregor gregor commented May 9, 2017

No description provided.

@lipis lipis mentioned this pull request May 9, 2017
79 tasks
Copy link
Contributor

@lipis lipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic numbers! :trollface:

keyboardJS: true
ko: true
libsodium: true
lorem_ipsum: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is lorem_ipsum being used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of the payloads.js. We might want to move this, entities and whatever is in there to a dedicated namespace in a separate PR.

@gregor gregor merged commit 32d76cc into dev May 9, 2017
@gregor gregor deleted the es6/tests branch May 9, 2017 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants