ES6 migrate 'conversation' #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregor
force-pushed
the
es6/conversation
branch
16 times, most recently
from
62d9264 to
edfd82f
Compare
lipis
reviewed
May 3, 2017
| } | ||
| } | ||
|
|
||
| asset_et.status(status || z.assets.AssetTransferState.UPLOADING); // TODO |
There was a problem hiding this comment.
Maybe more details for the //TODO or delete the comment..?
gregor
force-pushed
the
es6/conversation
branch
12 times, most recently
from
e10f961 to
0fc2acb
Compare
lipis
reviewed
May 4, 2017
| conversation_et.verification_state(self.verification_state); | ||
| } | ||
|
|
||
| // BE |
There was a problem hiding this comment.
To BE or not to BE?, Backend?, maybe remove it or have more context..
lipis
reviewed
May 4, 2017
| .map((other) => other.id); | ||
|
|
||
| if (!local_conversation.last_event_timestamp) { | ||
| local_conversation.last_event_timestamp = index + 1; // this should ensure a proper order |
There was a problem hiding this comment.
can we put the comment on top of the line?
herrmannplatz
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.