V3 group calls #1125
Merged
V3 group calls #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregor
force-pushed
the
feature/group-call
branch
12 times, most recently
from
7ff1480 to
5deb277
Compare
herrmannplatz
previously requested changes
Apr 26, 2017
app/script/calling/CallingService.js
Outdated
| constructor(client) { | ||
| this.logger = new z.util.Logger('z.calling.CallingService', z.config.LOGGER.OPTIONS); | ||
| this.client = client; | ||
| return this; |
| */ | ||
| _create_session_id() { | ||
| return new Array(E_CALL_MESSAGE_CONFIG.SESSION_ID_LENGTH) | ||
| .map(function() { |
app/script/calling/entities/EFlow.js
Outdated
| window.z.calling.entities = z.calling.entities || {}; | ||
|
|
||
| const E_FLOW_CONFIG = { | ||
| DATA_CHANNEL_LABEL: 'calling-3.0', |
There was a problem hiding this comment.
these const leak into the global space. so either add a closure or make them static
gregor
force-pushed
the
feature/group-call
branch
17 times, most recently
from
3e026a2 to
31f8b91
Compare
gregor
force-pushed
the
feature/group-call
branch
3 times, most recently
from
430c33a to
9aeea1a
Compare
gregor
force-pushed
the
feature/group-call
branch
2 times, most recently
from
6eaaa9b to
780cc80
Compare
added 20 commits
May 10, 2017 13:30
gregor
force-pushed
the
feature/group-call
branch
from
780cc80 to
d5988b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.