ES6: migrated "util" #1114
Merged
ES6: migrated "util" #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregor
suggested changes
Apr 24, 2017
app/script/main/app.coffee
Outdated
| @@ -239,7 +239,7 @@ class z.main.App | |||
| if is_reload and error.type not in [z.client.ClientError.TYPE.MISSING_ON_BACKEND, z.client.ClientError.TYPE.NO_LOCAL_CLIENT] | |||
| @auth.client.execute_on_connectivity(z.service.Client::CONNECTIVITY_CHECK_TRIGGER.APP_INIT_RELOAD).then -> window.location.reload false | |||
| else if navigator.onLine | |||
| @logger.error "Caused by: #{error?.message or error}" | |||
| @logger.error "Caused by: #{error?.message or error}", error | |||
There was a problem hiding this comment.
Problematic. If error is a string as it sometimes is and not the error object, we will end up with a log message that does no longer contain the "Caused by reference". Maybe we should be more explicit and do a proper _.isObject check with tow error logging cases.
There was a problem hiding this comment.
Hm, this is due to our logger implementation, right?
| return undefined; | ||
| } | ||
|
|
||
| for (let i = next_index; i <= array.length; i++) { |
There was a problem hiding this comment.
You have a proper array. We can use that:
for (const item of array) {
if(!_.isFunction(filter) || !!filter(item)) {
return item
}
}
| let hash = uint32.toUint32(0); | ||
| const key = str.toLowerCase(); | ||
|
|
||
| for (let i = 0; i <= key.length - 1; i++) { |
There was a problem hiding this comment.
for (const index of [0..key.length - 1])
| new_array[0] = array[0]; | ||
| new_array[length - 1] = array[array.length - 1]; | ||
|
|
||
| for (let i = 1; i < length - 1; i++) { |
There was a problem hiding this comment.
for (const index of [0..length - 1])
app/script/util/DebugUtil.js
Outdated
| this.logger = new z.util.Logger('z.util.DebugUtil', z.config.LOGGER.OPTIONS); | ||
| this.user_repository = user_repository; | ||
|
|
||
| this.get_event_info = this.get_event_info.bind(this); |
app/script/util/util.js
Outdated
| return window.URL.revokeObjectURL(object_url); | ||
| }; | ||
| img.onerror = reject; | ||
| return img.src = object_url; |
app/script/util/util.js
Outdated
| return resolve(this.result); | ||
| }; | ||
| reader.onerror = reject; | ||
| return reader.readAsArrayBuffer(file); |
app/script/util/util.js
Outdated
| if (typeof xhr_accessor_function === 'function') { | ||
| xhr_accessor_function(xhr); | ||
| } | ||
| return xhr.send(); |
app/script/util/util.js
Outdated
| return resolve([xhr.response, xhr.getResponseHeader('content-type')]); | ||
| } | ||
| return reject(new Error(`Requesting arraybuffer failed with status ${xhr.status}`)); | ||
|
|
app/script/util/worker.js
Outdated
| const worker = new window.Worker(uri); | ||
| worker.onmessage = (event) => resolve(event.data); | ||
| worker.onerror = (error) => reject(error); | ||
| return worker.postMessage(data); |
gregor
approved these changes
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PromiseQueue.coffeewill not be part of this conversion as per request from @gregor (he will convert it later).