ES6: migrated "entity/message" #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregor
reviewed
Apr 18, 2017
app/script/entity/message/Asset.js
Outdated
|
|
||
| /** | ||
| * Check if asset is a medium image. | ||
| * |
There was a problem hiding this comment.
Do we need all these empty lines in docs?
lipis
reviewed
Apr 18, 2017
|
|
||
| this.get_icon_classes = ko.pureComputed(() => { | ||
| let css_classes = this.accent_color(); | ||
| if ((Date.now() - this.timestamp()) < 2000) { |
lipis
approved these changes
Apr 18, 2017
gregor
approved these changes
Apr 19, 2017
gregor
suggested changes
Apr 19, 2017
app/script/entity/message/Message.js
Outdated
| * Check if the message content can be downloaded. | ||
| * @returns {Boolean} True, if the message has downloadable content. | ||
| */ | ||
| is_downloadable() { |
There was a problem hiding this comment.
Old code: return @get_first_asset?().download?
Something seems to be missing here
gregor
reviewed
Apr 20, 2017
app/script/entity/message/Message.js
Outdated
| if (asset_et && (typeof asset_et.download === 'function')) { | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
no need for this extra return, covered by 222
gregor
approved these changes
Apr 20, 2017
|
finally 🎉 |
|
Gut Ding will Weile haben. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Screenshot