ES6: migrated "extension" #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregor
force-pushed
the
extension
branch
7 times, most recently
from
01a09ca to
bbaaad4
Compare
herrmannplatz
suggested changes
Apr 18, 2017
| * @returns {Promise} Resolves with a random matching gif | ||
| */ | ||
| get_random_gif(options) { | ||
| return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
we can remove the promise
| */ | ||
| get_gifs(options) { | ||
| return new Promise((resolve, reject) => { | ||
| let offset = 0; |
|
|
||
| let index = 0; | ||
| while (index < options.number) { | ||
| const gif = gifs[index]; |
There was a problem hiding this comment.
for (let gif of gifs.slice(0, options.number)) instead of while
herrmannplatz
approved these changes
Apr 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.