ES6: migrated "system_notification" #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregor
force-pushed
the
es6/system-notification
branch
from
03ba96c to
b12240c
Compare
|
Maybe the tests as well in the same PR? |
gregor
force-pushed
the
es6/system-notification
branch
from
b12240c to
833cae9
Compare
|
@lipis: No, skipping that on purpose. If I change the tests at the same time I have not garantuee that the new code passes the old tests. I might make the same migration mistake in both test and code. Thuse lets keep this separate. |
gregor
force-pushed
the
es6/system-notification
branch
9 times, most recently
from
dcff225 to
b72573b
Compare
gregor
force-pushed
the
es6/system-notification
branch
from
b72573b to
62fccbc
Compare
bennycode
approved these changes
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.