ES6: migrate "localization" #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipis
commented
Apr 7, 2017
| if (valueAccessor == null) return; | ||
|
|
||
| let args = []; | ||
| let s = valueAccessor; |
There was a problem hiding this comment.
better name for s.. any suggestions?
bennycode
suggested changes
Apr 8, 2017
| if (valueAccessor == null) return; | ||
|
|
||
| let args = []; | ||
| let s = valueAccessor; |
There was a problem hiding this comment.
There is no @param id nor a @param replace. I only see @param valueAccessor.
There was a problem hiding this comment.
Next time comment under the right line so it will go away when fixed..
There was a problem hiding this comment.
Sure! I just didn't had my glasses on. :P
bennycode
approved these changes
Apr 12, 2017
gregor
suggested changes
Apr 12, 2017
app/script/localization/Localizer.js
Outdated
| } | ||
| } | ||
|
|
||
| /* |
gregor
approved these changes
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed the
strings.coffeetowebapp.jsto have more unique names on Crowdin (mainly because I don't want to lose all the translations there already. I already talked to the customer support of Crowdin and they were very helpful as recently there were some changes on their side and they don't support out of the box*.jsfiles :) Long story short.. it works!