ES6: migrated "connect" #1030
Merged
ES6: migrated "connect" #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herrmannplatz
suggested changes
Apr 7, 2017
| }).catch((error) => { | ||
| return this.logger.error(`Failed to import contacts from Google: ${error.message}`, error); | ||
| }); | ||
| } |
There was a problem hiding this comment.
get_contacts() {
return this._init_library()
.then(() => this._get_access_token())
.then((access_token) => this._get_contacts(access_token))
.catch((error) => {
return this.logger.error(`Failed to import contacts from Google: ${error.message}`, error);
});
}
|
|
||
| this.logger.info('Lazy loading Google Auth API'); | ||
| let script_node = document.createElement('script'); | ||
| script_node.src = 'https://apis.google.com/js/auth.js?onload=gapi_loaded'; |
| return new Promise((resolve, reject) => { | ||
| this.logger.info('Fetching address book from Google'); | ||
| let api_endpoint = 'https://www.google.com/m8/feeds/contacts/default/full'; | ||
| return $.get(`${api_endpoint}?access_token=${access_token}&alt=json&max-results=15000&v=3.0`) |
There was a problem hiding this comment.
we should use fetch for this at some point
| return new Promise((resolve, reject) => { | ||
| if (window.gapi.auth) { | ||
| let auth_token = window.gapi.auth.getToken(); | ||
| if (auth_token) { |
| } | ||
| return this._load_library(); | ||
| } | ||
|
|
There was a problem hiding this comment.
return window.gapi ? Promise().resolve() : this._load_library()
maybe
| this.logger.info('Google Contacts SDK error', error); | ||
| throw new z.connect.ConnectError(z.connect.ConnectError.prototype.TYPE.GOOGLE_DOWNLOAD); | ||
| }).then((response) => { | ||
| amplify.publish(z.event.WebApp.SEARCH.SHOW); |
| this.logger.warn('No contacts found for upload'); | ||
| throw new z.connect.ConnectError(z.connect.ConnectError.prototype.TYPE.NO_CONTACTS); | ||
| } else { | ||
| this.logger.info(`Uploading hashes of '${phone_book.cards.length}' contacts for matching`, phone_book); |
| return resolve(undefined); | ||
| } | ||
| let address_book = window.wAddressBook; | ||
| let phone_book = new z.connect.PhoneBook(this.properties_repository.self()); |
gregor
force-pushed
the
decaffeinate-connect
branch
9 times, most recently
from
f6e4e5f to
bdfe2fa
Compare
gregor
force-pushed
the
decaffeinate-connect
branch
from
bdfe2fa to
aff38e2
Compare
herrmannplatz
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.