Remove System.Reactive dependency #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
reviewed
Nov 4, 2024
|
|
||
| /// <inheritdoc /> | ||
| protected override void OnDetaching() | ||
| { | ||
| base.OnDetaching(); | ||
|
|
||
| _disposables?.Dispose(); | ||
| _disposable?.Dispose(); |
There was a problem hiding this comment.
Maybe set _disposable to null? Likely not necessary, but custom disposable instance might potentially leak something.
maxkatz6
reviewed
Nov 4, 2024
| /// Represents an <see cref="System.IDisposable"/> that executes a specified action when disposed. | ||
| /// </summary> | ||
| /// <param name="dispose">The action to execute when disposed.</param> | ||
| public class DisposableAction(System.Action dispose) : System.IDisposable |
There was a problem hiding this comment.
It can be internal, unless you want to keep it public for custom third party behaviors/triggers.
maxkatz6
reviewed
Nov 4, 2024
| @@ -64,5 +62,7 @@ protected override void OnAttachedToVisualTree(CompositeDisposable disposable) | |||
| } | |||
| }; | |||
| animation.RunAsync(AssociatedObject); | |||
There was a problem hiding this comment.
Just a question, should animation be cancelled, when this behavior is detached?
|
Looks good to me, other than hypothetical _disposable leak. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8